This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Missing unit test on unittest.TestResult to check for required arguments
Type: behavior Stage: patch review
Components: Tests Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: DreamSh0t, ezio.melotti, michael.foord, rbcollins, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-12-16 06:46 by DreamSh0t, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL Status Linked Edit
PR 30132 open DreamSh0t, 2021-12-16 06:52
Messages (4)
msg408674 - (view) Author: dhruv (DreamSh0t) * Date: 2021-12-16 06:46
stream, descriptions, and verbosity seem like they aren't needed at first glance but are required to work with multiple inheritance. A simple test can clarify this.
msg408691 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-12-16 11:42
What do you mean they are required? All parameters of TestResult() are optional.
msg408875 - (view) Author: dhruv (DreamSh0t) * Date: 2021-12-18 22:53
"Required" meaning that we cannot remove them from the constructor signature even though they aren't used within it. Hope that clears it up!
msg408897 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-12-19 13:12
These parameters were added in d99ef9a9df093d3443996725cd9dcac5f113f176, but they were not tested nor documented. An indirect test was added later in issue12376.

If it is an official feature it needs documentation and tests. Otherwise we can remove these parameters and revert issue12376 changes. Michael?
History
Date User Action Args
2022-04-11 14:59:53adminsetgithub: 90252
2021-12-19 13:12:28serhiy.storchakasetmessages: + msg408897
2021-12-18 22:53:06DreamSh0tsetmessages: + msg408875
2021-12-16 11:42:31serhiy.storchakasetstatus: pending -> open
nosy: + ezio.melotti, serhiy.storchaka, michael.foord, rbcollins
messages: + msg408691

2021-12-16 07:00:41DreamSh0tsetstatus: open -> pending
2021-12-16 06:52:38DreamSh0tsetkeywords: + patch
stage: patch review
pull_requests: + pull_request28351
2021-12-16 06:46:05DreamSh0tcreate